Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new fields to CredentialType schema, and minor bug fix. #339

Merged

Conversation

mjspi
Copy link
Collaborator

@mjspi mjspi commented May 1, 2024

Implemented the following within CredentialType schema:

  1. Added management.mode to CredentialType.
  2. Added required to CredentialTypeMetaDataFieldsInner.
  3. Set DeletedAt property to readonly per API specification.

Addresses issues #292, #293 and #338.

@mjspi mjspi added the enhancement New feature or request label May 1, 2024
@mjspi mjspi self-assigned this May 1, 2024
@mjspi mjspi requested a review from patrickcping as a code owner May 1, 2024 15:10
Copy link
Owner

@patrickcping patrickcping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🚀

@patrickcping patrickcping merged commit eae4551 into main May 1, 2024
17 checks passed
@patrickcping patrickcping deleted the 338-add-mgmt-mode-and-required-properties-credentialtype branch May 1, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants